diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2021-02-21 12:32:11 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2021-02-21 16:43:26 +0100 |
| commit | a659b3f1dc889d5ab5ead017b877765b3d042379 (patch) | |
| tree | 8df03976c96285623e94f39e7a44773170b0a9d8 /executor/android/android_seccomp.h | |
| parent | e894953c0c45c8a6d676292a81da90a615133b1c (diff) | |
pkg/report: detect executor failures
Currently all executor fail errors go into "lost connection" bucket.
This is not very useful. First, there are different executor failures.
Second, it's not possible to understand what failures happen how frequently.
Third, there are not authentic lost connection.
Create separate SYZFAIL: bugs for them.
Update #573
Update #502
Update #318
Diffstat (limited to 'executor/android/android_seccomp.h')
| -rw-r--r-- | executor/android/android_seccomp.h | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/executor/android/android_seccomp.h b/executor/android/android_seccomp.h index d8df52792..f3febac2c 100644 --- a/executor/android/android_seccomp.h +++ b/executor/android/android_seccomp.h @@ -46,7 +46,7 @@ typedef struct Filter_t { static void push_back(Filter* filter_array, struct sock_filter filter) { if (filter_array->count == kFilterMaxSize) - fail("can't add another syscall to seccomp filter: count %zu", filter_array->count); + failmsg("can't add another syscall to seccomp filter", "count=%zu", filter_array->count); filter_array->data[filter_array->count++] = filter; } @@ -79,9 +79,8 @@ static void install_filter(const Filter* f) (struct sock_filter*)&f->data[0], }; // This assumes either the current process has CAP_SYS_ADMIN, or PR_SET_NO_NEW_PRIVS bit is set. - if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog) < 0) { - fail("Could not set seccomp filter of size %zu", f->count); - } + if (prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, &prog) < 0) + failmsg("could not set seccomp filter", "size=%zu", f->count); } // Modified from the orignal Android code as we don't need dual arch support |