diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2021-09-29 11:50:13 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2021-09-29 12:53:52 +0200 |
| commit | e08fe93770083bf534bd468c3fb46ad26e57d83f (patch) | |
| tree | 684ad88f0750ea76eba0ae62a13be9513a3acc08 /docs | |
| parent | 81cc67e3a14a127f3983fa87c7be1cf9971c824f (diff) | |
vm/qemu: fix nil deref in qmp
A user has reported the following crash:
panic: runtime error: invalid memory address or nil pointer dereference
goroutine 1021 [running]:
github.com/google/syzkaller/vm/qemu.(*instance).qmp()
vm/qemu/qmp.go:96 +0x1c9
github.com/google/syzkaller/vm/qemu.(*instance).hmp()
vm/qemu/qmp.go:115 +0xbd
github.com/google/syzkaller/vm/qemu.(*instance).Diagnose()
vm/qemu/qemu.go:662 +0x18d
qmp function accesses resp even if doQmp returns an error
and doQmp can return a nil resp in this case if inst.monEnc.Encode fails.
Don't access resp if error is returned. The only caller hmp
does not use the returned object is an error is returned.
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions