aboutsummaryrefslogtreecommitdiffstats
path: root/docs/syzbot.md
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-04-10 13:36:15 +0200
committerGitHub <noreply@github.com>2018-04-10 13:36:15 +0200
commit8e873e9dc0be2d372877f027c6292040edda44bd (patch)
tree845b148d4140e795525dadfad319bfd1e1c7fff7 /docs/syzbot.md
parentb9f655072cffb76f8b33aca772bfda9eb3a4530d (diff)
Update syzbot.md
Diffstat (limited to 'docs/syzbot.md')
-rw-r--r--docs/syzbot.md20
1 files changed, 20 insertions, 0 deletions
diff --git a/docs/syzbot.md b/docs/syzbot.md
index 82912cd49..ee8c7e283 100644
--- a/docs/syzbot.md
+++ b/docs/syzbot.md
@@ -141,6 +141,26 @@ travelled through memory. Finally there is a "Uninit was created at:"
section which points either to a heap allocation or a stack variable which
is the original source of uninitialized-ness.
+## No custom patches
+
+While `syzbot` can test patches that fix bugs, it does not support applying
+custom patches during fuzzing. It always tests vanilla unmodified git trees.
+There are several reasons for this:
+
+- custom patches may not apply tomorrow
+- custom patches may not apply to all of the tested git trees
+- it's hard to communicate exact state of the code with bug reports (not just hash anymore)
+- line numbers won't match in reports (which always brings suspecion as to the quality of reports)
+- custom patches can also introduce bugs, and even if they don't a developer may (rightfully)
+ question validity of and may not want to spend time on reports obtained
+ with a number of out-of-tree patches
+- order of patch application generatelly matters, and at some point patches
+ need to be removed, there is nobody to manage this
+
+We've experimented with application of custom patches in the past and it lead
+to unrecoverable mess. If you want `syzbot` to pick up patches sooner,
+ask tree maintainers for priority handling.
+
## Is syzbot code available?
Yes, it is [here](https://github.com/google/syzkaller/tree/master/dashboard/app).