diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2026-01-15 10:36:25 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2026-01-15 14:22:40 +0000 |
| commit | 644a5033f43c5b2314e7a300ba7dc3e81b311662 (patch) | |
| tree | 0811edc135046e31b7bd6349f6ab62509f688ef1 /dashboard | |
| parent | 1b51e9a3ba38bfe09679fe437cece6645a6105d5 (diff) | |
dashboard/app: slightly improve coverage report wording
Use the proper namespace name to show.
+few minor tweaks
Diffstat (limited to 'dashboard')
| -rw-r--r-- | dashboard/app/reporting_email.go | 5 | ||||
| -rw-r--r-- | dashboard/app/reporting_test.go | 4 | ||||
| -rw-r--r-- | dashboard/app/templates/mail_ns_coverage.txt | 2 |
3 files changed, 6 insertions, 5 deletions
diff --git a/dashboard/app/reporting_email.go b/dashboard/app/reporting_email.go index 301da9ccc..93c2bbe11 100644 --- a/dashboard/app/reporting_email.go +++ b/dashboard/app/reporting_email.go @@ -169,6 +169,7 @@ func sendNsCoverageReport(ctx context.Context, ns, email string, if err != nil { return fmt.Errorf("coverageTable: %w", err) } + cfg := getNsConfig(ctx, ns) args := struct { Namespace string PeriodFrom string @@ -178,7 +179,7 @@ func sendNsCoverageReport(ctx context.Context, ns, email string, Link string Table string }{ - Namespace: ns, + Namespace: cfg.DisplayTitle, PeriodFrom: periodFrom, PeriodFromDays: period[0].Days, PeriodTo: periodTo, @@ -187,7 +188,7 @@ func sendNsCoverageReport(ctx context.Context, ns, email string, coveragePageLink(ns, period[1].Type, period[1].DateTo.String(), minDrop, 2, true)), Table: table, } - title := fmt.Sprintf("%s coverage regression in %s", ns, periodTo) + title := fmt.Sprintf("%s coverage regressions in %s", cfg.DisplayTitle, periodTo) err = sendMailTemplate(ctx, &mailSendParams{ templateName: "mail_ns_coverage.txt", templateArg: args, diff --git a/dashboard/app/reporting_test.go b/dashboard/app/reporting_test.go index 211797488..640eac30f 100644 --- a/dashboard/app/reporting_test.go +++ b/dashboard/app/reporting_test.go @@ -1406,10 +1406,10 @@ func TestCoverageRegression(t *testing.T) { assert.Equal(t, 1, len(c.emailSink)) msg := <-c.emailSink assert.Equal(t, []string{"test@test.test"}, msg.To) - assert.Equal(t, "coverage-tests coverage regression in December 1999", msg.Subject) + assert.Equal(t, "coverage-tests coverage regressions in December 1999", msg.Subject) wantLink := "https://testapp.appspot.com/coverage-tests/coverage?" + "dateto=1999-12-31&min-cover-lines-drop=1&order-by-cover-lines-drop=1&period=month&period_count=2" - assert.Equal(t, `Regressions happened in 'coverage-tests' from November 1999 (30 days) to December 1999 (31 days). + assert.Equal(t, `coverage-tests regressions in December 1999 (31 days) since November 1999 (30 days). Web version: `+wantLink+` Blocks diff, Path diff --git a/dashboard/app/templates/mail_ns_coverage.txt b/dashboard/app/templates/mail_ns_coverage.txt index 05eb7f934..4e8a41690 100644 --- a/dashboard/app/templates/mail_ns_coverage.txt +++ b/dashboard/app/templates/mail_ns_coverage.txt @@ -1,4 +1,4 @@ -Regressions happened in '{{.Namespace}}' from {{.PeriodFrom}} ({{.PeriodFromDays}} days) to {{.PeriodTo}} ({{.PeriodToDays}} days). +{{.Namespace}} regressions in {{.PeriodTo}} ({{.PeriodToDays}} days) since {{.PeriodFrom}} ({{.PeriodFromDays}} days). Web version: {{.Link}} {{.Table}} |