aboutsummaryrefslogtreecommitdiffstats
path: root/dashboard
diff options
context:
space:
mode:
authorTaras Madan <tarasmadan@google.com>2025-02-14 19:01:57 +0100
committerTaras Madan <tarasmadan@google.com>2025-02-17 08:18:57 +0000
commit4121cf9df313ee111c01fde1f255d010c8d941cd (patch)
treedcd0d104c8c35997103297dfb7dc1f0de6b77b8e /dashboard
parent9f05da3db0234203729d2ad179ab5a2f72bf607f (diff)
all: remove loop variables scoping
Diffstat (limited to 'dashboard')
-rw-r--r--dashboard/app/access_test.go1
-rw-r--r--dashboard/app/email_test.go1
-rw-r--r--dashboard/app/jobs.go2
-rw-r--r--dashboard/app/reporting_test.go1
-rw-r--r--dashboard/app/stats.go1
5 files changed, 0 insertions, 6 deletions
diff --git a/dashboard/app/access_test.go b/dashboard/app/access_test.go
index c5e74b1ac..c6363abf8 100644
--- a/dashboard/app/access_test.go
+++ b/dashboard/app/access_test.go
@@ -421,7 +421,6 @@ func TestAccess(t *testing.T) {
// In the short mode, only test that there's no public access to non-public URLs.
continue
}
- ent := ent
t.Run(fmt.Sprintf("level%d_%d", requestLevel, i), func(t *testing.T) {
reply := checkPage(t, requestLevel, ent.level, ent.url)
checkReferences(t, ent.url, requestLevel, reply)
diff --git a/dashboard/app/email_test.go b/dashboard/app/email_test.go
index c059bcfc6..18dd51993 100644
--- a/dashboard/app/email_test.go
+++ b/dashboard/app/email_test.go
@@ -473,7 +473,6 @@ func TestEmailDup(t *testing.T) {
func TestEmailDup2(t *testing.T) {
for i := 0; i < 4; i++ {
- i := i
t.Run(fmt.Sprint(i), func(t *testing.T) {
c := NewCtx(t)
defer c.Close()
diff --git a/dashboard/app/jobs.go b/dashboard/app/jobs.go
index 95fac0114..f5f629d81 100644
--- a/dashboard/app/jobs.go
+++ b/dashboard/app/jobs.go
@@ -1855,7 +1855,6 @@ func (j *bugJob) loadBuild(c context.Context) error {
func fullBackportInfo(c context.Context, list []*backportInfo) error {
crashLoader := &dependencyLoader[Crash]{}
for _, info := range list {
- info := info
if info.job.CrashID == 0 {
continue
}
@@ -1869,7 +1868,6 @@ func fullBackportInfo(c context.Context, list []*backportInfo) error {
}
buildLoader := &dependencyLoader[Build]{}
for _, info := range list {
- info := info
if info.crash == nil {
continue
}
diff --git a/dashboard/app/reporting_test.go b/dashboard/app/reporting_test.go
index e6d020786..aeadf72f1 100644
--- a/dashboard/app/reporting_test.go
+++ b/dashboard/app/reporting_test.go
@@ -1213,7 +1213,6 @@ func TestObsoletePeriod(t *testing.T) {
}
for _, test := range tests {
- test := test
t.Run(test.name, func(t *testing.T) {
ret := test.bug.obsoletePeriod(c)
assert.Equal(t, test.period, ret)
diff --git a/dashboard/app/stats.go b/dashboard/app/stats.go
index f206895e5..d74f0502a 100644
--- a/dashboard/app/stats.go
+++ b/dashboard/app/stats.go
@@ -84,7 +84,6 @@ func allBugInputs(c context.Context, ns string) ([]*bugInput, error) {
}
buildLoader := &dependencyLoader[Build]{}
for _, input := range inputs {
- input := input
if input.reportedCrash == nil {
continue
}