all: remove unused nolint directives

8 files changed, 2 insertions, 16 deletions

diff --git a/dashboard/app/access_test.go b/dashboard/app/access_test.go
index 1141f40ee..440f81f9b 100644
--- a/dashboard/app/access_test.go
+++ b/dashboard/app/access_test.go
@@ -43,7 +43,7 @@ func TestAccessConfig(t *testing.T) {
 }
 
 // TestAccess checks that all UIs respect access levels.
-// nolint: funlen, goconst, gocyclo
+// nolint: funlen, gocyclo
 func TestAccess(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()
diff --git a/dashboard/app/email_test.go b/dashboard/app/email_test.go
index b9cdfb88c..158ef09f8 100644
--- a/dashboard/app/email_test.go
+++ b/dashboard/app/email_test.go
@@ -1063,7 +1063,6 @@ func TestBugFromSubjectInference(t *testing.T) {
 	c.expectEQ(strings.Contains(email.Body, "This crash does not have a reproducer"), true)
 }
 
-// nolint: funlen
 func TestEmailLinks(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()
diff --git a/dashboard/app/graphs.go b/dashboard/app/graphs.go
index 068259135..77dcaf13a 100644
--- a/dashboard/app/graphs.go
+++ b/dashboard/app/graphs.go
@@ -122,7 +122,6 @@ type uiMultiInput struct {
 	Vals    []string
 }
 
-// nolint: dupl
 func handleKernelHealthGraph(c context.Context, w http.ResponseWriter, r *http.Request) error {
 	hdr, err := commonHeader(c, r, w, "")
 	if err != nil {
@@ -139,7 +138,6 @@ func handleKernelHealthGraph(c context.Context, w http.ResponseWriter, r *http.R
 	return serveTemplate(w, "graph_bugs.html", data)
 }
 
-// nolint: dupl
 func handleGraphLifetimes(c context.Context, w http.ResponseWriter, r *http.Request) error {
 	hdr, err := commonHeader(c, r, w, "")
 	if err != nil {
@@ -172,7 +170,6 @@ func handleGraphLifetimes(c context.Context, w http.ResponseWriter, r *http.Requ
 	return serveTemplate(w, "graph_lifetimes.html", data)
 }
 
-// nolint: dupl
 func handleFoundBugsGraph(c context.Context, w http.ResponseWriter, r *http.Request) error {
 	hdr, err := commonHeader(c, r, w, "")
 	if err != nil {
@@ -352,7 +349,6 @@ func createFoundBugs(c context.Context, bugs []*Bug) *uiGraph {
 	const projected = "projected"
 	// This is linux-specific at the moment, potentially can move to pkg/report/crash
 	// and extend to other OSes.
-	// nolint: lll
 	types := []struct {
 		name  string
 		color string
diff --git a/dashboard/app/jobs.go b/dashboard/app/jobs.go
index 9c1a9001e..85fc67a71 100644
--- a/dashboard/app/jobs.go
+++ b/dashboard/app/jobs.go
@@ -1032,7 +1032,6 @@ func resetJobs(c context.Context, req *dashapi.JobResetReq) error {
 }
 
 // doneJob is called by syz-ci to mark completion of a job.
-// nolint: gocyclo
 func doneJob(c context.Context, req *dashapi.JobDoneReq) error {
 	jobID := req.ID
 	jobKey, err := jobID2Key(c, req.ID)
diff --git a/dashboard/app/main.go b/dashboard/app/main.go
index 0c2c655c3..ce281a4fb 100644
--- a/dashboard/app/main.go
+++ b/dashboard/app/main.go
@@ -1072,7 +1072,7 @@ func handleAdmin(c context.Context, w http.ResponseWriter, r *http.Request) erro
 }
 
 // handleBug serves page about a single bug (which is passed in id argument).
-// nolint: funlen, gocyclo
+// nolint: gocyclo
 func handleBug(c context.Context, w http.ResponseWriter, r *http.Request) error {
 	bug, err := findBugByID(c, r)
 	if err != nil {
@@ -1185,13 +1185,11 @@ func handleBug(c context.Context, w http.ResponseWriter, r *http.Request) error
 	// - no fix bisections have been performed on the bug
 	// - fix bisection was performed but resulted in a crash on HEAD
 	// - there have been infrastructure problems during the job execution
-	// nolint: dupl
 	if len(bugDetails.BisectFixJobs) > 1 || len(bugDetails.BisectFixJobs) > 0 && bugDetails.BisectFixJob == nil {
 		data.Sections = append(data.Sections, makeCollapsibleBugJobs(
 			"Fix bisection attempts", bugDetails.BisectFixJobs))
 	}
 	// Similarly, a cause bisection can be repeated if there were infrastructure problems.
-	// nolint: dupl
 	if len(bugDetails.BisectCauseJobs) > 1 || len(bugDetails.BisectCauseJobs) > 0 && bugDetails.BisectCauseJob == nil {
 		data.Sections = append(data.Sections, makeCollapsibleBugJobs(
 			"Cause bisection attempts", bugDetails.BisectCauseJobs))
diff --git a/dashboard/app/reporting.go b/dashboard/app/reporting.go
index c5e6ff1e3..61bee541d 100644
--- a/dashboard/app/reporting.go
+++ b/dashboard/app/reporting.go
@@ -475,7 +475,6 @@ func reproStr(level dashapi.ReproLevel) string {
 	}
 }
 
-// nolint: gocyclo
 func createBugReport(c context.Context, bug *Bug, crash *Crash, crashKey *db.Key,
 	bugReporting *BugReporting, reporting *Reporting) (*dashapi.BugReport, error) {
 	var job *Job
diff --git a/dashboard/app/reporting_email.go b/dashboard/app/reporting_email.go
index b699074fb..236a95857 100644
--- a/dashboard/app/reporting_email.go
+++ b/dashboard/app/reporting_email.go
@@ -686,7 +686,6 @@ func processInboxEmail(c context.Context, msg *email.Email, inbox *PerInboxConfi
 	return forwardEmail(c, msg, missing, []string{cc, msg.Author}, "", msg.MessageID)
 }
 
-// nolint: gocyclo
 func processIncomingEmail(c context.Context, msg *email.Email) error {
 	// Ignore any incoming emails from syzbot itself.
 	if ownEmail(c) == msg.Author {
diff --git a/dashboard/app/subsystem_test.go b/dashboard/app/subsystem_test.go
index 065b01d9c..845bc41f3 100644
--- a/dashboard/app/subsystem_test.go
+++ b/dashboard/app/subsystem_test.go
@@ -286,7 +286,6 @@ func TestNoUserSubsystemOverwrite(t *testing.T) {
 	expectLabels(t, client, extID, "subsystems:subsystemA")
 }
 
-// nolint: goconst
 func TestPeriodicSubsystemReminders(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()
@@ -722,7 +721,6 @@ func TestSubsystemRemindersNoReport(t *testing.T) {
 	client.expectNoEmail()
 }
 
-// nolint: goconst
 func TestNoRemindersWithDiscussions(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()
@@ -827,7 +825,6 @@ You may send multiple commands in a single email message.
 `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a third"]))
 }
 
-// nolint: goconst
 func TestSkipSubsystemReminders(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()
@@ -999,7 +996,6 @@ You may send multiple commands in a single email message.
 `, bugToExtID["WARNING: a first"], bugToExtID["WARNING: a second"]))
 }
 
-// nolint: goconst
 func TestRemindersPriority(t *testing.T) {
 	c := NewCtx(t)
 	defer c.Close()