diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2026-02-19 13:10:31 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2026-02-19 15:25:05 +0000 |
| commit | c8d8c52d6e4d7bc5716f7e5848dad2de4aea55e1 (patch) | |
| tree | d1e09b4292614b320528630a8e62d1d9681c228a /dashboard/app/linux_reporting_test.go | |
| parent | 73a252ac8d271a17af0607da173d8821b8ce4311 (diff) | |
dashboard/app: fix API access checks
Currently we permit per-namespace clients to access global APIs.
For example, a secondary OS syz-manager client can poll bugs
from all namespaces. This is wrong and bad. Don't permit namespace
clients to access global APIs.
Diffstat (limited to 'dashboard/app/linux_reporting_test.go')
| -rw-r--r-- | dashboard/app/linux_reporting_test.go | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/dashboard/app/linux_reporting_test.go b/dashboard/app/linux_reporting_test.go index 9b1ce697c..14376c716 100644 --- a/dashboard/app/linux_reporting_test.go +++ b/dashboard/app/linux_reporting_test.go @@ -69,8 +69,8 @@ func TestFsSubsystemFlow(t *testing.T) { client.ReportCrash(crash) // As there's no other information, the bug is left at the first reporting. - c.client.pollNotifs(0) - vfsBug := client.pollBug() + c.globalClient.pollNotifs(0) + vfsBug := c.globalClient.pollBug() // D. Now report a reproducer for the (C) bug that does image mounting. // ----------------------------------------- @@ -89,8 +89,8 @@ renameat2(r0, &(0x7f00000004c0)='./file0\x00', r0, &(0x7f0000000500)='./bus/file client.ReportCrash(crash) // Check that we're ready for upstreaming. - c.client.pollNotifs(1) - client.updateBug(vfsBug.ID, dashapi.BugStatusUpstream, "") + c.globalClient.pollNotifs(1) + c.globalClient.updateBug(vfsBug.ID, dashapi.BugStatusUpstream, "") // .. and poll the email. reply = c.pollEmailBug() c.expectEQ(reply.Subject, "[syzbot] [ntfs3?] WARNING in do_mkdirat") @@ -127,8 +127,8 @@ func TestVfsSubsystemFlow(t *testing.T) { client.ReportCrash(crash) // As there's no other information, the bug is left at the first reporting. - c.client.pollNotifs(0) - vfsBug := client.pollBug() + c.globalClient.pollNotifs(0) + vfsBug := c.globalClient.pollBug() // B. Now report a reproducer for the (C) bug that does NO image mounting. // ----------------------------------------- @@ -145,8 +145,8 @@ renameat2(r0, &(0x7f00000004c0)='./file0\x00', r0, &(0x7f0000000500)='./bus/file client.ReportCrash(crash) // Check that we're ready for upstreaming. - c.client.pollNotifs(1) - client.updateBug(vfsBug.ID, dashapi.BugStatusUpstream, "") + c.globalClient.pollNotifs(1) + c.globalClient.updateBug(vfsBug.ID, dashapi.BugStatusUpstream, "") // .. and poll the email. reply := c.pollEmailBug() c.expectEQ(reply.Subject, "[syzbot] [fs?] WARNING in do_mkdirat2") |