diff options
| author | Sabyrzhan Tasbolatov <snovitoll@gmail.com> | 2024-09-05 22:59:26 +0500 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2024-09-09 17:11:19 +0000 |
| commit | 784df80e01554d5cd451f0b4e23171297863e115 (patch) | |
| tree | 346d0d65fd4d4f09b578efe7ed01ac2876944db1 /dashboard/app/api.go | |
| parent | cb2d8b3aef0920cbb5521f948e262598efc3fc1c (diff) | |
dashboard/app: priority of revoked & no repro
If there are non-revoked reproducers, we will always prefer them to the revoked
ones. And we do update the priority once we have revoked
a reproducer. But if the only reproducer was revoked,
we still give that crash a higher priority than other crashes,
which never had a reproducer attached.
If "repro revoked" should have the same priority as "no repro",
then we just need to update Crash.UpdateReportingPriority.
Fixes: https://github.com/google/syzkaller/issues/4992.
Diffstat (limited to 'dashboard/app/api.go')
| -rw-r--r-- | dashboard/app/api.go | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/dashboard/app/api.go b/dashboard/app/api.go index c65e91386..4375b19b5 100644 --- a/dashboard/app/api.go +++ b/dashboard/app/api.go @@ -905,14 +905,10 @@ func parseCrashAssets(c context.Context, req *dashapi.Crash) ([]Asset, error) { func (crash *Crash) UpdateReportingPriority(c context.Context, build *Build, bug *Bug) { prio := int64(kernelRepoInfo(c, build).ReportingPriority) * 1e6 - divReproPrio := int64(1) - if crash.ReproIsRevoked { - divReproPrio = 10 - } - if crash.ReproC > 0 { - prio += 4e12 / divReproPrio - } else if crash.ReproSyz > 0 { - prio += 2e12 / divReproPrio + if crash.ReproC > 0 && !crash.ReproIsRevoked { + prio += 4e12 + } else if crash.ReproSyz > 0 && !crash.ReproIsRevoked { + prio += 2e12 } if crash.Title == bug.Title { prio += 1e8 // prefer reporting crash that matches bug title |