diff options
| author | Taras Madan <tarasmadan@google.com> | 2023-07-04 10:25:58 +0200 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2023-07-04 10:06:59 +0000 |
| commit | f99c2404dd2b0d6c554896e04666fa345832be6f (patch) | |
| tree | b71e33ea77d5a3e0446d571ae3740367960a7216 | |
| parent | 07d54a36cb61c452b838befe3b09a2787b4e52fe (diff) | |
dashboard/app: export bug id
Let's assume we don't know fixing commit.
Exporting bug id we allow external systems to group our reports.
| -rw-r--r-- | dashboard/app/getjson_test.go | 8 | ||||
| -rw-r--r-- | dashboard/app/main.go | 2 | ||||
| -rw-r--r-- | dashboard/app/public_json_api.go | 2 |
3 files changed, 10 insertions, 2 deletions
diff --git a/dashboard/app/getjson_test.go b/dashboard/app/getjson_test.go index da611b7d6..113053e26 100644 --- a/dashboard/app/getjson_test.go +++ b/dashboard/app/getjson_test.go @@ -14,6 +14,7 @@ func TestJSONAPIIntegration(t *testing.T) { sampleCrashDescr := []byte(`{ "version": 1, "title": "title1", + "id": "cb1dbe55dc6daa7e739a0d09a0ae4d5e3e5a10c8", "crashes": [ { "title": "title1", @@ -29,6 +30,7 @@ func TestJSONAPIIntegration(t *testing.T) { sampleCrashWithReproDescr := []byte(`{ "version": 1, "title": "title2", + "id": "fc00fbc0cddd9a4ef2ae33e40cd21636081466ce", "crashes": [ { "title": "title2", @@ -129,6 +131,7 @@ func TestJSONAPIFixCommits(t *testing.T) { want := []byte(`{ "version": 1, "title": "title1", + "id": "cb1dbe55dc6daa7e739a0d09a0ae4d5e3e5a10c8", "fix-commits": [ { "title": "foo: fix1", @@ -168,9 +171,10 @@ func TestJSONAPICauseBisection(t *testing.T) { url := fmt.Sprintf("/bug?id=%v&json=1", bugKey.StringID()) content, err := c.GET(url) c.expectEQ(err, nil) - c.expectEQ(string(content), string(`{ + c.expectEQ(string(content), `{ "version": 1, "title": "title1", + "id": "70ce63ecb151d563976728208edccc6879191f9f", "cause-commit": { "title": "kernel: add a bug", "hash": "36e65cb4a0448942ec316b24d60446bbd5cc7827", @@ -188,5 +192,5 @@ func TestJSONAPICauseBisection(t *testing.T) { "syzkaller-commit": "syzkaller_commit1" } ] -}`)) +}`) } diff --git a/dashboard/app/main.go b/dashboard/app/main.go index 2b481b254..80a730164 100644 --- a/dashboard/app/main.go +++ b/dashboard/app/main.go @@ -325,6 +325,7 @@ type uiBug struct { LastActivity time.Time Labels []*uiBugLabel Discussions DiscussionSummary + ID string } type uiBugLabel struct { @@ -1576,6 +1577,7 @@ func createUIBug(c context.Context, bug *Bug, state *ReportingState, managers [] NumManagers: len(managers), LastActivity: bug.LastActivity, Discussions: bug.discussionSummary(), + ID: bug.keyHash(), } for _, entry := range bug.Labels { uiBug.Labels = append(uiBug.Labels, makeBugLabelUI(c, bug, entry)) diff --git a/dashboard/app/public_json_api.go b/dashboard/app/public_json_api.go index a1ac660e3..87ee5663a 100644 --- a/dashboard/app/public_json_api.go +++ b/dashboard/app/public_json_api.go @@ -12,6 +12,7 @@ import ( type publicAPIBugDescription struct { Version int `json:"version"` Title string `json:"title,omitempty"` + ID string `json:"id"` FixCommits []vcsCommit `json:"fix-commits,omitempty"` CauseCommit *vcsCommit `json:"cause-commit,omitempty"` // links to the discussions @@ -44,6 +45,7 @@ func getExtAPIDescrForBugPage(bugPage *uiBugPage) *publicAPIBugDescription { return &publicAPIBugDescription{ Version: 1, Title: bugPage.Bug.Title, + ID: bugPage.Bug.ID, Discussions: func() []string { if bugPage.Bug.ExternalLink == "" { return nil |