diff options
| author | Taras Madan <tarasmadan@google.com> | 2024-08-26 12:32:02 +0200 |
|---|---|---|
| committer | Taras Madan <tarasmadan@google.com> | 2024-08-27 15:12:58 +0000 |
| commit | e4f3ea1bc2e083feadcf5a6083a5d7e74e9fc53e (patch) | |
| tree | d9efa4202bea3cee892525837201d188c782179c | |
| parent | 5fc2677b4aeffac87aef5092b99ca41ccefa57fa (diff) | |
pkg/covermerger: add tooltips to every coverage number
Hover mouse onto the percent value to see details.
To test:
$ go run ./tools/syz-cover -heatmap upstream -from 2024-08-23 -to 2024-08-23
$ google-chrome upstream.html
| -rw-r--r-- | pkg/cover/heatmap.go | 3 | ||||
| -rw-r--r-- | pkg/cover/heatmap_test.go | 22 | ||||
| -rw-r--r-- | pkg/cover/templates/heatmap.html | 26 |
3 files changed, 48 insertions, 3 deletions
diff --git a/pkg/cover/heatmap.go b/pkg/cover/heatmap.go index 1d0f04b9d..4de56fbec 100644 --- a/pkg/cover/heatmap.go +++ b/pkg/cover/heatmap.go @@ -28,6 +28,7 @@ type templateHeatmapRow struct { IsDir bool Depth int LastDayInstrumented int64 + Tooltips []string builder map[string]*templateHeatmapRow instrumented map[civil.Date]int64 @@ -74,6 +75,8 @@ func (thm *templateHeatmapRow) prepareDataFor(dates []civil.Date) { dateCoverage = 100 * thm.covered[d] / thm.instrumented[d] } thm.Coverage = append(thm.Coverage, dateCoverage) + thm.Tooltips = append(thm.Tooltips, fmt.Sprintf("Instrumented:\t%d blocks\nCovered:\t%d blocks", + thm.instrumented[d], thm.covered[d])) } if len(dates) > 0 { lastDate := dates[len(dates)-1] diff --git a/pkg/cover/heatmap_test.go b/pkg/cover/heatmap_test.go index 3d54f5b40..f83b31191 100644 --- a/pkg/cover/heatmap_test.go +++ b/pkg/cover/heatmap_test.go @@ -46,6 +46,9 @@ func TestFilesCoverageToTemplateData(t *testing.T) { IsDir: false, Depth: 0, LastDayInstrumented: 1, + Tooltips: []string{ + "Instrumented:\t1 blocks\nCovered:\t1 blocks", + }, }, }, Name: "", @@ -53,6 +56,9 @@ func TestFilesCoverageToTemplateData(t *testing.T) { IsDir: false, Depth: 0, LastDayInstrumented: 1, + Tooltips: []string{ + "Instrumented:\t1 blocks\nCovered:\t1 blocks", + }, }, Dates: []string{"2024-07-01"}, }, @@ -85,6 +91,10 @@ func TestFilesCoverageToTemplateData(t *testing.T) { IsDir: false, Depth: 1, LastDayInstrumented: 0, + Tooltips: []string{ + "Instrumented:\t1 blocks\nCovered:\t1 blocks", + "Instrumented:\t0 blocks\nCovered:\t0 blocks", + }, }, { Items: []*templateHeatmapRow{}, @@ -93,6 +103,10 @@ func TestFilesCoverageToTemplateData(t *testing.T) { IsDir: false, Depth: 1, LastDayInstrumented: 1, + Tooltips: []string{ + "Instrumented:\t0 blocks\nCovered:\t0 blocks", + "Instrumented:\t1 blocks\nCovered:\t0 blocks", + }, }, }, Name: "dir", @@ -100,11 +114,19 @@ func TestFilesCoverageToTemplateData(t *testing.T) { IsDir: true, Depth: 0, LastDayInstrumented: 1, + Tooltips: []string{ + "Instrumented:\t1 blocks\nCovered:\t1 blocks", + "Instrumented:\t1 blocks\nCovered:\t0 blocks", + }, }, }, Name: "", Coverage: []int64{100, 0}, LastDayInstrumented: 1, + Tooltips: []string{ + "Instrumented:\t1 blocks\nCovered:\t1 blocks", + "Instrumented:\t1 blocks\nCovered:\t0 blocks", + }, }, Dates: []string{"2024-07-01", "2024-07-02"}, }, diff --git a/pkg/cover/templates/heatmap.html b/pkg/cover/templates/heatmap.html index ba39b00f5..622a27636 100644 --- a/pkg/cover/templates/heatmap.html +++ b/pkg/cover/templates/heatmap.html @@ -91,6 +91,25 @@ .data_row:hover { background-color: #ffff99 !important; } + .cover_percent { + position: relative; + display: inline-block; + } + .cover_percent .tooltiptext { + visibility: hidden; + background-color: black; + color: #fff; + text-align: left; + border-radius: 6px; + padding: 5px 0; + + /* Position the tooltip */ + position: absolute; + z-index: 1; + } + .cover_percent:hover .tooltiptext { + visibility: visible; + } {{ end }} {{ define "body" }} @@ -137,9 +156,10 @@ {{$child.Name}} </div> </div> - {{ range $cov := $child.Coverage }} - <div class="date_column"> - {{ $cov }}% + {{ range $i, $cov := $child.Coverage }} + <div class="date_column cover_percent"> + {{$cov}}% + <pre class="tooltiptext">{{ index $child.Tooltips $i }}</pre> </div> {{ end }} <div class="instrumented_column"> |