aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2019-01-24 14:39:12 +0100
committerDmitry Vyukov <dvyukov@google.com>2019-01-24 16:49:38 +0100
commitde746e82320ebed3f7b02820728fa6eb035bc313 (patch)
treedc190197e7d1cf0be3f5f18b98181db502c6323f
parent44e061b86c622251bca6adb5358800a3827930b3 (diff)
sys/linux: update TODO comments
Change TODO comments that refer to missing description language features to NEED comments as that it's easier to grep for them. Remove some outdated comments. Fix 2 easy fixable TODOs.
-rw-r--r--executor/defs.h10
-rw-r--r--sys/fuchsia/ddk.txt2
-rw-r--r--sys/linux/aio.txt3
-rw-r--r--sys/linux/bpf.txt6
-rw-r--r--sys/linux/fs_btrfs.txt2
-rw-r--r--sys/linux/gen/386.go6
-rw-r--r--sys/linux/gen/amd64.go6
-rw-r--r--sys/linux/gen/arm.go6
-rw-r--r--sys/linux/gen/arm64.go6
-rw-r--r--sys/linux/gen/ppc64le.go6
-rw-r--r--sys/linux/kvm.txt4
-rw-r--r--sys/linux/netfilter_bridge.txt4
-rw-r--r--sys/linux/perf.txt2
-rw-r--r--sys/linux/ppp.txt3
-rw-r--r--sys/linux/rdma_cm.txt4
-rw-r--r--sys/linux/sg.txt4
-rw-r--r--sys/linux/socket_netlink_route_sched.txt13
-rw-r--r--sys/linux/sys.txt4
-rw-r--r--sys/linux/trusty.txt2
-rw-r--r--sys/linux/udmabuf.txt2
-rw-r--r--sys/linux/vnet.txt2
21 files changed, 45 insertions, 52 deletions
diff --git a/executor/defs.h b/executor/defs.h
index bb00161ae..286d20407 100644
--- a/executor/defs.h
+++ b/executor/defs.h
@@ -60,7 +60,7 @@
#if GOARCH_386
#define GOARCH "386"
-#define SYZ_REVISION "1c5197fbb1cb70ac384135081dec18423f4e1bd1"
+#define SYZ_REVISION "73de2b833c2b5be4c3abdb751cfb1bbad822cb5e"
#define SYZ_EXECUTOR_USES_FORK_SERVER 1
#define SYZ_EXECUTOR_USES_SHMEM 1
#define SYZ_PAGE_SIZE 4096
@@ -70,7 +70,7 @@
#if GOARCH_amd64
#define GOARCH "amd64"
-#define SYZ_REVISION "3f0e0ea59ae728d37a8cdd5e77a5beeb718a88f6"
+#define SYZ_REVISION "cd2f1ce2ae2e840980b5dfe5927c341879b4a173"
#define SYZ_EXECUTOR_USES_FORK_SERVER 1
#define SYZ_EXECUTOR_USES_SHMEM 1
#define SYZ_PAGE_SIZE 4096
@@ -80,7 +80,7 @@
#if GOARCH_arm
#define GOARCH "arm"
-#define SYZ_REVISION "3391e0fa8ed2299b0beda67f40c24a913c0b6a5b"
+#define SYZ_REVISION "37ed12d6836fb030db385600279ed827c692c8e9"
#define SYZ_EXECUTOR_USES_FORK_SERVER 1
#define SYZ_EXECUTOR_USES_SHMEM 1
#define SYZ_PAGE_SIZE 4096
@@ -90,7 +90,7 @@
#if GOARCH_arm64
#define GOARCH "arm64"
-#define SYZ_REVISION "d0d53f46334e628e33432e1655016df33dda9386"
+#define SYZ_REVISION "d396c31fbc1aadb2f099a6f1fd81ee9b94d112e3"
#define SYZ_EXECUTOR_USES_FORK_SERVER 1
#define SYZ_EXECUTOR_USES_SHMEM 1
#define SYZ_PAGE_SIZE 4096
@@ -100,7 +100,7 @@
#if GOARCH_ppc64le
#define GOARCH "ppc64le"
-#define SYZ_REVISION "e8c9edb8f62f65ca64b9679162b4e5995ad2aaa9"
+#define SYZ_REVISION "880948f9b7814b04a67d1aaceb1a13ca2263c4f6"
#define SYZ_EXECUTOR_USES_FORK_SERVER 1
#define SYZ_EXECUTOR_USES_SHMEM 1
#define SYZ_PAGE_SIZE 4096
diff --git a/sys/fuchsia/ddk.txt b/sys/fuchsia/ddk.txt
index 0ad5bee76..fc6569d19 100644
--- a/sys/fuchsia/ddk.txt
+++ b/sys/fuchsia/ddk.txt
@@ -10,4 +10,4 @@ zx_cache_flush(addr ptr[out, intptr], size int64, flags flags[cache_flush_flags]
zx_interrupt_create(src_obj const[0], src_num const[0], options const[ZX_INTERRUPT_VIRTUAL], interrupt ptr[out, zx_interrupt])
zx_interrupt_ack(interrupt zx_interrupt)
zx_interrupt_destroy(interrupt zx_interrupt)
-# TODO fill out remaining interrupt syscalls
+# TODO: fill out remaining interrupt syscalls
diff --git a/sys/linux/aio.txt b/sys/linux/aio.txt
index cc513b8dd..950a1e47e 100644
--- a/sys/linux/aio.txt
+++ b/sys/linux/aio.txt
@@ -9,8 +9,7 @@ io_setup(n int32, ctx ptr[out, io_ctx])
io_destroy(ctx io_ctx)
io_getevents(ctx io_ctx, min_nr intptr, nr len[events], events ptr[out, array[io_event]], timeout ptr[in, timespec, opt])
io_pgetevents(ctx io_ctx, min_nr intptr, nr len[events], events ptr[out, array[io_event]], timeout ptr[in, timespec, opt], usig ptr[in, sigset_size, opt])
-# TODO: kernel identifies requets by address, so pointers passed to io_submit
-# need to be forwarded to io_cancel somehow.
+# NEED: kernel identifies requets by address, so pointers passed to io_submit need to be forwarded to io_cancel somehow.
io_submit(ctx io_ctx, nr len[iocbpp], iocbpp ptr[in, array[ptr[in, iocb]]])
io_cancel(ctx io_ctx, iocb ptr[in, iocb], res ptr[out, io_event])
diff --git a/sys/linux/bpf.txt b/sys/linux/bpf.txt
index 21dd512c7..cffaa4619 100644
--- a/sys/linux/bpf.txt
+++ b/sys/linux/bpf.txt
@@ -263,7 +263,7 @@ bpf_reg = BPF_REG_0, BPF_REG_1, BPF_REG_2, BPF_REG_3, BPF_REG_4, BPF_REG_5, BPF_
define MAX_BPF_REG __MAX_BPF_REG
-# TODO: these filenames must be on bpf filesystem
+# NEED: these filenames must be on bpf filesystem, can we do it somehow?
bpf_obj_pin_map {
path ptr64[in, filename]
fd fd_bpf_map
@@ -390,7 +390,7 @@ btf_header {
type_off const[0, int32]
type_len bytesize[types, int32]
str_off bytesize[parent, int32]
-# TODO: should be bytesize[bpf_btf_program.strings]
+# NEED: should be bytesize[bpf_btf_program.strings]
str_len int32
types bpf_btf_types
}
@@ -407,7 +407,7 @@ bpf_btf_strings {
} [packed]
bpf_task_fd_query {
-# TODO: part of fields are input here and part are output. We can't express this yet (#245).
+# NEED: part of fields are input here and part are output. We can't express this yet (#245).
pid pid
fd fd_perf_base
flags const[0, int32]
diff --git a/sys/linux/fs_btrfs.txt b/sys/linux/fs_btrfs.txt
index b113bb663..b31ac5156 100644
--- a/sys/linux/fs_btrfs.txt
+++ b/sys/linux/fs_btrfs.txt
@@ -3,5 +3,5 @@
include <uapi/linux/btrfs.h>
-# TODO add the ioctls
+# TODO: add the ioctls
_ = BTRFS_IOC_SNAP_CREATE, BTRFS_IOC_DEFRAG, BTRFS_IOC_RESIZE, BTRFS_IOC_SCAN_DEV, BTRFS_IOC_TRANS_START, BTRFS_IOC_TRANS_END, BTRFS_IOC_SYNC, BTRFS_IOC_CLONE, BTRFS_IOC_ADD_DEV, BTRFS_IOC_RM_DEV, BTRFS_IOC_BALANCE, BTRFS_IOC_CLONE_RANGE, BTRFS_IOC_SUBVOL_CREATE, BTRFS_IOC_SNAP_DESTROY, BTRFS_IOC_FILE_EXTENT_SAME
diff --git a/sys/linux/gen/386.go b/sys/linux/gen/386.go
index 9f80d523a..ea9236e06 100644
--- a/sys/linux/gen/386.go
+++ b/sys/linux/gen/386.go
@@ -18890,7 +18890,7 @@ var structDescs_386 = []*KeyedStruct{
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "sbp", TypeSize: 4}, Type: &BufferType{TypeCommon: TypeCommon{TypeName: "array", ArgDir: 1, IsVarlen: true}}},
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "timeout", TypeSize: 4}}},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_flags", FldName: "flags", TypeSize: 4}}, Vals: []uint64{1, 2, 4, 65536, 16, 32}, BitMask: true},
- &FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_pack_id", FldName: "pack_id", TypeSize: 4}}, Vals: []uint64{18446744073709551615, 0, 1, 2, 3}},
+ &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "pack_id", TypeSize: 4}}, Kind: 2, RangeBegin: 18446744073709551615, RangeEnd: 3},
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "usr_ptr", TypeSize: 4}, Type: &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int8", TypeSize: 1, ArgDir: 1}}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "status", TypeSize: 1}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "masked_status", TypeSize: 1}}},
@@ -21023,7 +21023,7 @@ var structDescs_386 = []*KeyedStruct{
}}},
{Key: StructKey{Name: "tcf_em_nbyte"}, Desc: &StructDesc{TypeCommon: TypeCommon{TypeName: "tcf_em_nbyte", IsVarlen: true}, Fields: []Type{
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "off", TypeSize: 4}}},
- &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int16", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, Kind: 2, RangeEnd: 10},
+ &LenType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "bytesize", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, BitSize: 8, Buf: "payload"},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "tcf_layers", FldName: "layer", TypeSize: 1}, BitfieldLen: 4}, Vals: []uint64{0, 1, 2}, BitMask: true},
&BufferType{TypeCommon: TypeCommon{TypeName: "array", FldName: "payload", IsVarlen: true}, Kind: 1, RangeEnd: 10},
}, AlignAttr: 4}},
@@ -46828,4 +46828,4 @@ var consts_386 = []ConstValue{
{Name: "bpf_insn_load_imm_dw", Value: 24},
}
-const revision_386 = "1c5197fbb1cb70ac384135081dec18423f4e1bd1"
+const revision_386 = "73de2b833c2b5be4c3abdb751cfb1bbad822cb5e"
diff --git a/sys/linux/gen/amd64.go b/sys/linux/gen/amd64.go
index 5c248531b..6e920c870 100644
--- a/sys/linux/gen/amd64.go
+++ b/sys/linux/gen/amd64.go
@@ -19233,7 +19233,7 @@ var structDescs_amd64 = []*KeyedStruct{
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "sbp", TypeSize: 8}, Type: &BufferType{TypeCommon: TypeCommon{TypeName: "array", ArgDir: 1, IsVarlen: true}}},
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "timeout", TypeSize: 4}}},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_flags", FldName: "flags", TypeSize: 4}}, Vals: []uint64{1, 2, 4, 65536, 16, 32}, BitMask: true},
- &FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_pack_id", FldName: "pack_id", TypeSize: 4}}, Vals: []uint64{18446744073709551615, 0, 1, 2, 3}},
+ &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "pack_id", TypeSize: 4}}, Kind: 2, RangeBegin: 18446744073709551615, RangeEnd: 3},
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "usr_ptr", TypeSize: 8}, Type: &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int8", TypeSize: 1, ArgDir: 1}}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "status", TypeSize: 1}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "masked_status", TypeSize: 1}}},
@@ -21394,7 +21394,7 @@ var structDescs_amd64 = []*KeyedStruct{
}}},
{Key: StructKey{Name: "tcf_em_nbyte"}, Desc: &StructDesc{TypeCommon: TypeCommon{TypeName: "tcf_em_nbyte", IsVarlen: true}, Fields: []Type{
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "off", TypeSize: 4}}},
- &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int16", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, Kind: 2, RangeEnd: 10},
+ &LenType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "bytesize", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, BitSize: 8, Buf: "payload"},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "tcf_layers", FldName: "layer", TypeSize: 1}, BitfieldLen: 4}, Vals: []uint64{0, 1, 2}, BitMask: true},
&BufferType{TypeCommon: TypeCommon{TypeName: "array", FldName: "payload", IsVarlen: true}, Kind: 1, RangeEnd: 10},
}, AlignAttr: 4}},
@@ -47618,4 +47618,4 @@ var consts_amd64 = []ConstValue{
{Name: "bpf_insn_load_imm_dw", Value: 24},
}
-const revision_amd64 = "3f0e0ea59ae728d37a8cdd5e77a5beeb718a88f6"
+const revision_amd64 = "cd2f1ce2ae2e840980b5dfe5927c341879b4a173"
diff --git a/sys/linux/gen/arm.go b/sys/linux/gen/arm.go
index 4df935bbc..dc06ea864 100644
--- a/sys/linux/gen/arm.go
+++ b/sys/linux/gen/arm.go
@@ -18758,7 +18758,7 @@ var structDescs_arm = []*KeyedStruct{
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "sbp", TypeSize: 4}, Type: &BufferType{TypeCommon: TypeCommon{TypeName: "array", ArgDir: 1, IsVarlen: true}}},
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "timeout", TypeSize: 4}}},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_flags", FldName: "flags", TypeSize: 4}}, Vals: []uint64{1, 2, 4, 65536, 16, 32}, BitMask: true},
- &FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_pack_id", FldName: "pack_id", TypeSize: 4}}, Vals: []uint64{18446744073709551615, 0, 1, 2, 3}},
+ &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "pack_id", TypeSize: 4}}, Kind: 2, RangeBegin: 18446744073709551615, RangeEnd: 3},
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "usr_ptr", TypeSize: 4}, Type: &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int8", TypeSize: 1, ArgDir: 1}}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "status", TypeSize: 1}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "masked_status", TypeSize: 1}}},
@@ -20904,7 +20904,7 @@ var structDescs_arm = []*KeyedStruct{
}}},
{Key: StructKey{Name: "tcf_em_nbyte"}, Desc: &StructDesc{TypeCommon: TypeCommon{TypeName: "tcf_em_nbyte", IsVarlen: true}, Fields: []Type{
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "off", TypeSize: 4}}},
- &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int16", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, Kind: 2, RangeEnd: 10},
+ &LenType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "bytesize", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, BitSize: 8, Buf: "payload"},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "tcf_layers", FldName: "layer", TypeSize: 1}, BitfieldLen: 4}, Vals: []uint64{0, 1, 2}, BitMask: true},
&BufferType{TypeCommon: TypeCommon{TypeName: "array", FldName: "payload", IsVarlen: true}, Kind: 1, RangeEnd: 10},
}, AlignAttr: 4}},
@@ -46667,4 +46667,4 @@ var consts_arm = []ConstValue{
{Name: "bpf_insn_load_imm_dw", Value: 24},
}
-const revision_arm = "3391e0fa8ed2299b0beda67f40c24a913c0b6a5b"
+const revision_arm = "37ed12d6836fb030db385600279ed827c692c8e9"
diff --git a/sys/linux/gen/arm64.go b/sys/linux/gen/arm64.go
index b2b8e8155..ea431b3aa 100644
--- a/sys/linux/gen/arm64.go
+++ b/sys/linux/gen/arm64.go
@@ -19050,7 +19050,7 @@ var structDescs_arm64 = []*KeyedStruct{
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "sbp", TypeSize: 8}, Type: &BufferType{TypeCommon: TypeCommon{TypeName: "array", ArgDir: 1, IsVarlen: true}}},
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "timeout", TypeSize: 4}}},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_flags", FldName: "flags", TypeSize: 4}}, Vals: []uint64{1, 2, 4, 65536, 16, 32}, BitMask: true},
- &FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_pack_id", FldName: "pack_id", TypeSize: 4}}, Vals: []uint64{18446744073709551615, 0, 1, 2, 3}},
+ &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "pack_id", TypeSize: 4}}, Kind: 2, RangeBegin: 18446744073709551615, RangeEnd: 3},
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "usr_ptr", TypeSize: 8}, Type: &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int8", TypeSize: 1, ArgDir: 1}}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "status", TypeSize: 1}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "masked_status", TypeSize: 1}}},
@@ -21211,7 +21211,7 @@ var structDescs_arm64 = []*KeyedStruct{
}}},
{Key: StructKey{Name: "tcf_em_nbyte"}, Desc: &StructDesc{TypeCommon: TypeCommon{TypeName: "tcf_em_nbyte", IsVarlen: true}, Fields: []Type{
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "off", TypeSize: 4}}},
- &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int16", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, Kind: 2, RangeEnd: 10},
+ &LenType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "bytesize", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, BitSize: 8, Buf: "payload"},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "tcf_layers", FldName: "layer", TypeSize: 1}, BitfieldLen: 4}, Vals: []uint64{0, 1, 2}, BitMask: true},
&BufferType{TypeCommon: TypeCommon{TypeName: "array", FldName: "payload", IsVarlen: true}, Kind: 1, RangeEnd: 10},
}, AlignAttr: 4}},
@@ -46976,4 +46976,4 @@ var consts_arm64 = []ConstValue{
{Name: "bpf_insn_load_imm_dw", Value: 24},
}
-const revision_arm64 = "d0d53f46334e628e33432e1655016df33dda9386"
+const revision_arm64 = "d396c31fbc1aadb2f099a6f1fd81ee9b94d112e3"
diff --git a/sys/linux/gen/ppc64le.go b/sys/linux/gen/ppc64le.go
index 9fd0f1500..581c2cf50 100644
--- a/sys/linux/gen/ppc64le.go
+++ b/sys/linux/gen/ppc64le.go
@@ -18947,7 +18947,7 @@ var structDescs_ppc64le = []*KeyedStruct{
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "sbp", TypeSize: 8}, Type: &BufferType{TypeCommon: TypeCommon{TypeName: "array", ArgDir: 1, IsVarlen: true}}},
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "timeout", TypeSize: 4}}},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_flags", FldName: "flags", TypeSize: 4}}, Vals: []uint64{1, 2, 4, 65536, 16, 32}, BitMask: true},
- &FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "sg_pack_id", FldName: "pack_id", TypeSize: 4}}, Vals: []uint64{18446744073709551615, 0, 1, 2, 3}},
+ &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "pack_id", TypeSize: 4}}, Kind: 2, RangeBegin: 18446744073709551615, RangeEnd: 3},
&PtrType{TypeCommon: TypeCommon{TypeName: "ptr", FldName: "usr_ptr", TypeSize: 8}, Type: &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int8", TypeSize: 1, ArgDir: 1}}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "status", TypeSize: 1}}},
&ConstType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "const", FldName: "masked_status", TypeSize: 1}}},
@@ -21093,7 +21093,7 @@ var structDescs_ppc64le = []*KeyedStruct{
}}},
{Key: StructKey{Name: "tcf_em_nbyte"}, Desc: &StructDesc{TypeCommon: TypeCommon{TypeName: "tcf_em_nbyte", IsVarlen: true}, Fields: []Type{
&IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int32", FldName: "off", TypeSize: 4}}},
- &IntType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "int16", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, Kind: 2, RangeEnd: 10},
+ &LenType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "bytesize", FldName: "len", TypeSize: 2}, BitfieldLen: 12}, BitSize: 8, Buf: "payload"},
&FlagsType{IntTypeCommon: IntTypeCommon{TypeCommon: TypeCommon{TypeName: "tcf_layers", FldName: "layer", TypeSize: 1}, BitfieldLen: 4}, Vals: []uint64{0, 1, 2}, BitMask: true},
&BufferType{TypeCommon: TypeCommon{TypeName: "array", FldName: "payload", IsVarlen: true}, Kind: 1, RangeEnd: 10},
}, AlignAttr: 4}},
@@ -44334,4 +44334,4 @@ var consts_ppc64le = []ConstValue{
{Name: "bpf_insn_load_imm_dw", Value: 24},
}
-const revision_ppc64le = "e8c9edb8f62f65ca64b9679162b4e5995ad2aaa9"
+const revision_ppc64le = "880948f9b7814b04a67d1aaceb1a13ca2263c4f6"
diff --git a/sys/linux/kvm.txt b/sys/linux/kvm.txt
index 226fc9bc3..54ca2d7d0 100644
--- a/sys/linux/kvm.txt
+++ b/sys/linux/kvm.txt
@@ -76,7 +76,7 @@ ioctl$KVM_INTERRUPT(fd fd_kvmcpu, cmd const[KVM_INTERRUPT], arg ptr[in, int32])
ioctl$KVM_GET_MSRS(fd fd_kvmcpu, cmd const[KVM_GET_MSRS], arg ptr[out, kvm_msrs])
ioctl$KVM_SET_MSRS(fd fd_kvmcpu, cmd const[KVM_SET_MSRS], arg ptr[in, kvm_msrs])
ioctl$KVM_SET_CPUID(fd fd_kvmcpu, cmd const[KVM_SET_CPUID], arg ptr[in, kvm_cpuid])
-# TODO: we should be able to read kvm_cpuid2 with KVM_GET_CPUID2, alter few bits and then call KVM_SET_CPUID2 with that object.
+# NEED: we should be able to read kvm_cpuid2 with KVM_GET_CPUID2, alter few bits and then call KVM_SET_CPUID2 with that object.
ioctl$KVM_GET_CPUID2(fd fd_kvmcpu, cmd const[KVM_GET_CPUID2], arg ptr[out, kvm_cpuid2])
ioctl$KVM_SET_CPUID2(fd fd_kvmcpu, cmd const[KVM_SET_CPUID2], arg ptr[in, kvm_cpuid2])
ioctl$KVM_SET_SIGNAL_MASK(fd fd_kvmcpu, cmd const[KVM_SET_SIGNAL_MASK], arg ptr[in, kvm_signal_mask])
@@ -621,7 +621,7 @@ kvm_sregs {
idt kvm_dtable
cr0 flags[kvm_x86_cr0, int64]
cr2 const[0, int64]
-#TODO: this should point to page table
+# TODO: this should point to page table
cr3 flags[kvm_guest_addrs, int64]
cr4 flags[kvm_x86_cr4, int64]
cr8 int64[0:15]
diff --git a/sys/linux/netfilter_bridge.txt b/sys/linux/netfilter_bridge.txt
index 5bdd38fe7..35ea752d1 100644
--- a/sys/linux/netfilter_bridge.txt
+++ b/sys/linux/netfilter_bridge.txt
@@ -91,7 +91,7 @@ ebt_entry_matches {
sourcemsk mac_addr_mask
destmac mac_addr
destmsk mac_addr_mask
-# TODO: this asks for an offset type (field offset).
+# NEED: this asks for an offset type (field offset).
watchers_offset bytesize[parent, int32]
target_offset bytesize[ebt_entry_watchers, int32]
next_offset bytesize[ebt_entry, int32]
@@ -199,7 +199,7 @@ ebt_802_3_info {
ebt_802_3_flags = EBT_802_3_SAP, EBT_802_3_TYPE, EBT_802_3
ebt_among_info {
-# TODO: these 2 fields are offsets of dst and src
+# NEED: these 2 fields are offsets of dst and src
# dst and src can also be not present in the struct, in which case ofs are 0
wh_dst_ofs int32
wh_src_ofs int32
diff --git a/sys/linux/perf.txt b/sys/linux/perf.txt
index 2b94968bb..fd29a6f1d 100644
--- a/sys/linux/perf.txt
+++ b/sys/linux/perf.txt
@@ -43,7 +43,7 @@ _ = PERF_COUNT_SW_CPU_CLOCK, PERF_COUNT_SW_TASK_CLOCK, PERF_COUNT_SW_PAGE_FAULTS
perf_event_attr {
type flags[perf_event_type, int32]
size len[parent, int32]
-#TODO: config can contain lots of various flags depending on type.
+# TODO: config can contain lots of various flags depending on type.
# this is a hacky way to generate something reasonable.
config0 int8
config1 int8
diff --git a/sys/linux/ppp.txt b/sys/linux/ppp.txt
index 2d1f9249a..20ad25261 100644
--- a/sys/linux/ppp.txt
+++ b/sys/linux/ppp.txt
@@ -30,8 +30,7 @@ ioctl$PPPIOCSPASS(fd fd_ppp, cmd const[PPPIOCSPASS], arg ptr[in, sock_fprog])
ioctl$PPPIOCSACTIVE(fd fd_ppp, cmd const[PPPIOCSACTIVE], arg ptr[in, sock_fprog])
ioctl$PPPIOCSMRRU(fd fd_ppp, cmd const[PPPIOCSMRRU], arg ptr[in, int32])
-# TODO: these ioctl's are also defined for sock_pppox.
-# We need multiple inheritance here (#322).
+# NEED: these ioctl's are also defined for sock_pppox. We need multiple inheritance here (#322).
ioctl$PPPIOCSMRU1(fd fd_ppp, cmd const[PPPIOCSMRU], arg ptr[in, int32])
ioctl$PPPIOCSFLAGS1(fd fd_ppp, cmd const[PPPIOCSFLAGS], arg ptr[in, flags[ppp_flags, int32]])
ioctl$PPPIOCGFLAGS1(fd fd_ppp, cmd const[PPPIOCGFLAGS], arg ptr[out, int32])
diff --git a/sys/linux/rdma_cm.txt b/sys/linux/rdma_cm.txt
index 700a62c83..b2d193e41 100644
--- a/sys/linux/rdma_cm.txt
+++ b/sys/linux/rdma_cm.txt
@@ -41,8 +41,8 @@ write$RDMA_USER_CM_CMD_JOIN_MCAST(fd fd_rdma_cm, data ptr[in, rdma_ucm_cmd_t[RDM
type rdma_ucm_cmd_t[CMD, MSG] {
cmd const[CMD, int32]
in bytesize[msg, int16]
-# TODO: this seems to be only checked for less, so we can get away with a large const.
-# TODO: A properer support would require support for bytesize[MSG.response] syntax.
+# NEED: this seems to be only checked for less, so we can get away with a large const.
+# NEED: A properer support would require support for bytesize[MSG.response] syntax.
out const[64000, int16]
msg MSG
}
diff --git a/sys/linux/sg.txt b/sys/linux/sg.txt
index 864e7c74f..8953a1f11 100644
--- a/sys/linux/sg.txt
+++ b/sys/linux/sg.txt
@@ -58,7 +58,7 @@ sg_io_hdr {
sbp ptr[out, array[int8]]
timeout int32
flags flags[sg_flags, int32]
- pack_id flags[sg_pack_id, int32]
+ pack_id int32[-1:3]
usr_ptr ptr[out, int8]
status const[0, int8]
masked_status const[0, int8]
@@ -110,8 +110,6 @@ scsi_ioctl_probe_host_out_buffer {
sg_interface_id = 0, 'S'
sg_dxfer_direction = SG_DXFER_NONE, SG_DXFER_TO_DEV, SG_DXFER_FROM_DEV, SG_DXFER_TO_FROM_DEV, SG_DXFER_UNKNOWN
sg_flags = SG_FLAG_DIRECT_IO, SG_FLAG_UNUSED_LUN_INHIBIT, SG_FLAG_MMAP_IO, SG_FLAG_NO_DXFER, SG_FLAG_Q_AT_TAIL, SG_FLAG_Q_AT_HEAD
-# TODO: we need negative integers for -1
-sg_pack_id = -1, 0, 1, 2, 3
define SG_MAX_CDB_SIZE 252
define SG_REQUEST_TABLE_SIZE SG_MAX_QUEUE * sizeof(sg_req_info_t)
diff --git a/sys/linux/socket_netlink_route_sched.txt b/sys/linux/socket_netlink_route_sched.txt
index 0bda3b691..4824616d3 100644
--- a/sys/linux/socket_netlink_route_sched.txt
+++ b/sys/linux/socket_netlink_route_sched.txt
@@ -300,7 +300,7 @@ tc_cbs_qopt {
sendslope int32
}
-# TODO: limit >= qth_max >= qth_min
+# NEED: limit >= qth_max >= qth_min
tc_red_qopt {
limit int32
qth_min int32
@@ -558,7 +558,7 @@ f_bpf_options [
TCA_BPF_ACT nlattr[TCA_BPF_ACT, tca_actions]
TCA_BPF_POLICE nlattr[TCA_BPF_POLICE, tca_polices]
TCA_BPF_CLASSID nlattr[TCA_BPF_CLASSID, tcm_handle]
-# TODO: TCA_BPF_OPS should equal to TCA_BPF_OPS_LEN * sizeof(struct sock_filter)
+# NEED: TCA_BPF_OPS should equal to TCA_BPF_OPS_LEN * sizeof(struct sock_filter)
TCA_BPF_OPS_LEN nlattr[TCA_BPF_OPS_LEN, int16[0:10]]
TCA_BPF_OPS nlattr[TCA_BPF_OPS, array[sock_filter]]
TCA_BPF_FD nlattr[TCA_BPF_FD, fd]
@@ -679,7 +679,7 @@ tc_u32_sel {
keys array[tc_u32_key, 0:128]
}
-# TODO: (mark.val & mark.mask) should equal to mark.val
+# NEED: (mark.val & mark.mask) should equal to mark.val
tc_u32_mark {
val int32
mask int32
@@ -747,7 +747,7 @@ tca_ife_meta_policy [
IFE_META_TCINDEX nlattr[IFE_META_TCINDEX, optional[int16]]
] [varlen]
-#TODO: add TCA_IPT_TARG support
+# TODO: add TCA_IPT_TARG support
m_ipt_options [
TCA_IPT_TABLE nlattr[TCA_IPT_TABLE, string[ipt_tables, IFNAMSIZ]]
TCA_IPT_HOOK nlattr[TCA_IPT_HOOK, flags[nf_inet_hooks, int32]]
@@ -1015,9 +1015,8 @@ tcf_em_cmp {
tcf_em_nbyte {
off int32
- len int16:12[0:10]
+ len bytesize[payload, int16:12]
layer flags[tcf_layers, int8:4]
-# TODO: The payload data len should be equal to tcf_em_nbyte.len
payload array[int8, 0:10]
} [align_4]
@@ -1072,7 +1071,7 @@ tc_estimator {
stab_policy [
TCA_STAB_BASE nlattr[TCA_STAB_BASE, tc_sizespec]
-# TODO: stab data should be tc_sizespec.tsize * sizeof(__u16)
+# NEED: stab data should be tc_sizespec.tsize * sizeof(__u16)
TCA_STAB_DATA nlattr[TCA_STAB_DATA, array[int16, 0:10]]
] [varlen]
diff --git a/sys/linux/sys.txt b/sys/linux/sys.txt
index e9732266c..a17d9d2fc 100644
--- a/sys/linux/sys.txt
+++ b/sys/linux/sys.txt
@@ -125,7 +125,7 @@ eventfd2(initval int32, flags flags[eventfd_flags]) fd_event
read$eventfd(fd fd_event, val ptr[out, int64], len len[val])
write$eventfd(fd fd_event, val ptr[in, int64], len len[val])
-# TODO: offset must be page-aligned. Or does the syscall even accept offset in pages?
+# NEED: offset must be page-aligned. Or does the syscall even accept offset in pages?
mmap(addr vma, len len[addr], prot flags[mmap_prot], flags flags[mmap_flags], fd fd, offset fileoff)
munmap(addr vma, len len[addr])
mremap(addr vma, len len[addr], newlen len[newaddr], flags flags[mremap_flags], newaddr vma)
@@ -630,7 +630,7 @@ sigevent_u [
define SIGEVENT_SIZE sizeof(struct sigevent)
sigevent_thread {
-# TODO: this is function pointer and pthread_attr_t (?)
+# NEED: this is function pointer and pthread_attr_t (?)
func buffer[in]
attr buffer[in]
}
diff --git a/sys/linux/trusty.txt b/sys/linux/trusty.txt
index 9e915c3da..3c1dba8da 100644
--- a/sys/linux/trusty.txt
+++ b/sys/linux/trusty.txt
@@ -267,7 +267,7 @@ type trusty_authorization_elem_t[TAG, DATA] {
} [packed]
trusty_authorization_bytes {
-# TODO: these are length/offset in trusty_authorization_set.indirect_data.
+# NEED: these are length/offset in trusty_authorization_set.indirect_data.
data_length int32
offset int32
} [packed]
diff --git a/sys/linux/udmabuf.txt b/sys/linux/udmabuf.txt
index 03b5d8b3d..16c2b4366 100644
--- a/sys/linux/udmabuf.txt
+++ b/sys/linux/udmabuf.txt
@@ -29,5 +29,5 @@ udmabuf_create_item {
size flags[udmabuf_offset_size, int64]
}
-# TODO: this should be a page-aligned integer
+# NEED: this should be a page-aligned integer
udmabuf_offset_size = 0, 0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x1000000, 0x100000000, 0xfffff000, 0x1000000000000, 0xfffffffffffff000, 0xfffffffff0000000
diff --git a/sys/linux/vnet.txt b/sys/linux/vnet.txt
index 01f0a4a5f..f26235a30 100644
--- a/sys/linux/vnet.txt
+++ b/sys/linux/vnet.txt
@@ -292,8 +292,6 @@ x25_packet {
payload array[int8]
} [packed]
-# TODO: open x25 sockets from userspace
-
################################################################################
##################################### IPv4 #####################################
################################################################################