aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Pratt <mpratt@google.com>2018-12-12 14:10:57 -0800
committerDmitry Vyukov <dvyukov@google.com>2018-12-13 09:38:49 +0100
commitd5cf08b04e971ca055c7e799178b879bd8eeb56e (patch)
tree0bda9c1c1dba8267d8cb0e7e0d4d11aa31814081
parentc9d6aae44b610603b1401c14ba89963a78ba4318 (diff)
vm/gvisor: don't close conn on error
If net.Dial returns an error, conn is nil and closing it will panic.
-rw-r--r--vm/gvisor/gvisor.go1
1 files changed, 0 insertions, 1 deletions
diff --git a/vm/gvisor/gvisor.go b/vm/gvisor/gvisor.go
index 82f4a871e..76a88e352 100644
--- a/vm/gvisor/gvisor.go
+++ b/vm/gvisor/gvisor.go
@@ -312,7 +312,6 @@ func (inst *instance) guestProxy() (*os.File, error) {
guestSock := os.NewFile(uintptr(socks[1]), "guest unix proxy")
conn, err := net.Dial("tcp", fmt.Sprintf("localhost:%v", inst.port))
if err != nil {
- conn.Close()
hostSock.Close()
guestSock.Close()
return nil, err