aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-02-26 17:46:44 +0100
committerDmitry Vyukov <dvyukov@google.com>2018-02-26 17:46:44 +0100
commitd1322dff4c35c033147ce97845e394576d42d7e9 (patch)
tree51e1de072e52416a42d55407787e33e4388a744f
parent1d19aa5799f95ef214351cfe7e94ffe64247dbee (diff)
prog: remove stale TODOs
-rw-r--r--prog/encoding.go2
-rw-r--r--prog/minimization.go1
-rw-r--r--prog/rand.go1
3 files changed, 1 insertions, 3 deletions
diff --git a/prog/encoding.go b/prog/encoding.go
index 507279289..375cd361a 100644
--- a/prog/encoding.go
+++ b/prog/encoding.go
@@ -276,7 +276,7 @@ func (target *Target) parseArg(typ Type, p *parser, vars map[string]Arg) (Arg, e
if _, ok := v.(ArgUsed); !ok {
// TODO(dvyukov): this happens during loading of old programs.
// Figure out when exactly this happens and if it is repairable.
- return nil, fmt.Errorf("result %v references vad type %#v", id, v)
+ return nil, fmt.Errorf("result %v references bad type %#v", id, v)
}
arg = MakeResultArg(typ, v, 0)
if p.Char() == '/' {
diff --git a/prog/minimization.go b/prog/minimization.go
index f74ad0252..ea5072c97 100644
--- a/prog/minimization.go
+++ b/prog/minimization.go
@@ -173,7 +173,6 @@ func Minimize(p0 *Prog, callIndex0 int, crash bool, pred0 func(*Prog, int) bool)
}
p0 = p
case *VmaType, *LenType, *CsumType, *ConstType:
- // TODO: try to remove offset from vma
return false
default:
panic(fmt.Sprintf("unknown arg type '%+v'", typ))
diff --git a/prog/rand.go b/prog/rand.go
index 2143a4b57..97571b7ea 100644
--- a/prog/rand.go
+++ b/prog/rand.go
@@ -151,7 +151,6 @@ func (r *randGen) flags(vv []uint64) (v uint64) {
}
func (r *randGen) filename(s *state) string {
- // TODO: support procfs and sysfs
dir := "."
if r.oneOf(2) && len(s.files) != 0 {
files := make([]string, 0, len(s.files))