diff options
| author | Dmitry Vyukov <dvyukov@google.com> | 2024-10-21 11:53:41 +0200 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2024-10-24 09:34:38 +0000 |
| commit | af2638df2c9e396d35a593598d4d30a078d855e7 (patch) | |
| tree | a6c16b8a5849a76c2dfd1a6e68ae5b971bb92d06 | |
| parent | 3fd4a86f3f8adfcfba5c642babd90bb4f5eecd3c (diff) | |
executor: don't kill executor exec process group
Killing a process group (negative pid) only makes sense
when the process is a group leader (called setsid/setpgrp/setpgid).
Executor exec process is not a group leader,
so don't try to kill its group. For our controlled executor
subprocesses we rely on PR_SET_PDEATHSIG for reliable
killing of all child subprocesses.
| -rw-r--r-- | executor/subprocess.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/executor/subprocess.h b/executor/subprocess.h index 2553422a9..5e638c1f5 100644 --- a/executor/subprocess.h +++ b/executor/subprocess.h @@ -76,7 +76,6 @@ public: { if (!pid_) fail("subprocess hasn't started or already waited"); - kill(-pid_, SIGKILL); kill(pid_, SIGKILL); int pid = 0; int wstatus = 0; |