aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2019-05-20 19:15:53 +0200
committerDmitry Vyukov <dvyukov@google.com>2019-05-20 19:40:20 +0200
commit7b3084af2ea815515ea35f9904ee38b5991e58d5 (patch)
tree82dcba4219ff80d0ca3a123a319182031a206a35
parent32ebe81cf3e222b41b03b774ce59bee2e7ec923f (diff)
syz-manager: don't repro non-leaks on leak instance
Leak checking is too slow to reproduce other bugs.
-rw-r--r--syz-manager/manager.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/syz-manager/manager.go b/syz-manager/manager.go
index fa1d9f0d2..f92b51724 100644
--- a/syz-manager/manager.go
+++ b/syz-manager/manager.go
@@ -23,6 +23,7 @@ import (
"github.com/google/syzkaller/pkg/db"
"github.com/google/syzkaller/pkg/gce"
"github.com/google/syzkaller/pkg/hash"
+ "github.com/google/syzkaller/pkg/host"
"github.com/google/syzkaller/pkg/instance"
"github.com/google/syzkaller/pkg/log"
"github.com/google/syzkaller/pkg/mgrconfig"
@@ -673,6 +674,11 @@ func (mgr *Manager) needLocalRepro(crash *Crash) bool {
if !mgr.cfg.Reproduce || crash.Corrupted {
return false
}
+ if mgr.checkResult.Features[host.FeatureLeakChecking].Enabled &&
+ crash.Type != report.MemoryLeak {
+ // Leak checking is very slow, don't bother reproducing other crashes.
+ return false
+ }
sig := hash.Hash([]byte(crash.Title))
dir := filepath.Join(mgr.crashdir, sig.String())
if osutil.IsExist(filepath.Join(dir, "repro.prog")) {