aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAleksandr Nogikh <nogikh@google.com>2022-12-19 18:22:11 +0100
committerAleksandr Nogikh <wp32pw@gmail.com>2022-12-20 09:57:25 +0100
commit4791c8e9d55c8717073396d3f46791ebbd3cf6a5 (patch)
treea220293d5dc07d72839ede7a6a439a053942eb90
parentc52b2efbf83e9d66fa9fa7b5416aa8eb4b839f20 (diff)
dashboard: don't retest revoked reproducers
We are already quite cautious re. the retest results -- the reproducer is preserved if we have any type of crash/error. It seems to be highly unlikely that, once the reproducer stopped to cause any crashes at all, that it will start working again.
-rw-r--r--dashboard/app/jobs.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/dashboard/app/jobs.go b/dashboard/app/jobs.go
index e31b0ae81..d94c08b09 100644
--- a/dashboard/app/jobs.go
+++ b/dashboard/app/jobs.go
@@ -311,6 +311,10 @@ func handleRetestForBug(c context.Context, now time.Time, bug *Bug, bugKey *db.K
if now.Sub(crash.LastReproRetest) < config.Obsoleting.ReproRetestPeriod {
continue
}
+ if crash.ReproIsRevoked {
+ // No sense in retesting the already revoked repro.
+ continue
+ }
// TODO: check if the manager can do such jobs.
if managerHasJob[crash.Manager] {
continue