aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2018-12-13 12:22:49 +0100
committerDmitry Vyukov <dvyukov@google.com>2018-12-13 12:22:49 +0100
commit3f9ec663653495bfaeeb0a2f2dfce01f2820bb01 (patch)
tree13e615353c3a5af7edb7cca99b7b579377ed33f2
parentf3d9d5948cad441ab08e763c8ed86efe79f4198b (diff)
pkg/report: relaxed gvisor OOM suppressions
Existing ones don't match actual gvisor output after address mangling. Not matching exact context in parens should be good enough re false positives.
-rw-r--r--pkg/report/gvisor.go6
-rw-r--r--pkg/report/testdata/gvisor/report/1716
2 files changed, 19 insertions, 3 deletions
diff --git a/pkg/report/gvisor.go b/pkg/report/gvisor.go
index f4b478929..c2d33f7e2 100644
--- a/pkg/report/gvisor.go
+++ b/pkg/report/gvisor.go
@@ -22,9 +22,9 @@ func ctorGvisor(target *targets.Target, kernelSrc, kernelObj string,
suppressions := []string{
"fatal error: runtime: out of memory",
"fatal error: runtime: cannot allocate memory",
- "panic: ptrace sysemu failed: no such process", // OOM kill
- `panic: ptrace set fpregs \(&{.*}\) failed: no such process`, // OOM kill
- `panic: ptrace set regs \(&{.*}\) failed: no such process`, // OOM kill
+ "panic: ptrace sysemu failed: no such process", // OOM kill
+ `panic: ptrace set fpregs \(.*\) failed: no such process`, // OOM kill
+ `panic: ptrace set regs \(.*\) failed: no such process`, // OOM kill
"panic: failed to start executor binary",
"panic: executor failed: pthread_create failed",
"panic: error mapping run data: error mapping runData: cannot allocate memory",
diff --git a/pkg/report/testdata/gvisor/report/17 b/pkg/report/testdata/gvisor/report/17
new file mode 100644
index 000000000..1da86dbdd
--- /dev/null
+++ b/pkg/report/testdata/gvisor/report/17
@@ -0,0 +1,16 @@
+TITLE: panic: ptrace set fpregs (ADDR) failed: no such process
+SUPPRESSED: Y
+
+panic: ptrace set fpregs (0xc000dd9300) failed: no such process
+
+goroutine 29103 [running]:
+gvisor.googlesource.com/gvisor/pkg/sentry/platform/ptrace.(*subprocess).switchToApp(0xc000636780, 0xc00061e780, 0xd2c720, 0xc00061d560, 0xc000ce9e00)
+ pkg/sentry/platform/ptrace/subprocess.go:486 +0x9e7
+gvisor.googlesource.com/gvisor/pkg/sentry/platform/ptrace.(*context).Switch(0xc00061e780, 0xd1e340, 0xc000636780, 0xd2c720, 0xc00061d560, 0x7f57ffffffff, 0x0, 0x0, 0x0, 0x0)
+ pkg/sentry/platform/ptrace/ptrace.go:102 +0x74
+gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*runApp).execute(0x0, 0xc000489500, 0xd119c0, 0x0)
+ pkg/sentry/kernel/task_run.go:205 +0x348
+gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*Task).run(0xc000489500, 0x108)
+ pkg/sentry/kernel/task_run.go:91 +0x149
+created by gvisor.googlesource.com/gvisor/pkg/sentry/kernel.(*Task).Start
+ pkg/sentry/kernel/task_start.go:279 +0xfe