aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Vyukov <dvyukov@google.com>2020-09-26 18:05:38 +0200
committerDmitry Vyukov <dvyukov@google.com>2020-09-28 09:41:25 +0200
commit3bbd2f185f56d7677df2bce8937cba4f3a04ece7 (patch)
tree97fe778fe6a204d19512cc7d55f7c02925c606c8
parent5dd8aee810424d4c1b06252f59ae59416fcacc55 (diff)
pkg/cover: unexport CSVHeader
No point for it to be a part of the package public interface. Follow up to #2074
-rw-r--r--pkg/cover/report.go16
-rw-r--r--pkg/cover/report_test.go2
2 files changed, 9 insertions, 9 deletions
diff --git a/pkg/cover/report.go b/pkg/cover/report.go
index 0a65c11a7..ebf884002 100644
--- a/pkg/cover/report.go
+++ b/pkg/cover/report.go
@@ -42,13 +42,6 @@ type symbol struct {
end uint64
}
-var CSVHeader = []string{
- "Filename",
- "Function",
- "Covered PCs",
- "Total PCs",
-}
-
func MakeReportGenerator(target *targets.Target, kernelObject, srcDir, buildDir string) (*ReportGenerator, error) {
rg := &ReportGenerator{
target: target,
@@ -208,9 +201,16 @@ func getFunction(functions map[string]*function, name string) *function {
return f
}
+var csvHeader = []string{
+ "Filename",
+ "Function",
+ "Covered PCs",
+ "Total PCs",
+}
+
func (rg *ReportGenerator) generateCSV(w io.Writer, progs []Prog, files map[string]*file) error {
data := [][]string{
- CSVHeader,
+ csvHeader,
}
for fname, file := range files {
diff --git a/pkg/cover/report_test.go b/pkg/cover/report_test.go
index f2253032d..644476a2f 100644
--- a/pkg/cover/report_test.go
+++ b/pkg/cover/report_test.go
@@ -197,7 +197,7 @@ func checkCSVReport(t *testing.T, CSVReport []byte) {
t.Fatal(err)
}
- if !reflect.DeepEqual(lines[0], CSVHeader) {
+ if !reflect.DeepEqual(lines[0], csvHeader) {
t.Fatalf("Heading line in CSV doesn't match %v", lines[0])
}