diff options
| author | Anton Lindqvist <anton@basename.se> | 2020-12-05 17:03:11 +0100 |
|---|---|---|
| committer | Dmitry Vyukov <dvyukov@google.com> | 2020-12-09 06:58:05 +0100 |
| commit | 0cf8cfe99da5b555b835f967f3b3cd43f542c0f4 (patch) | |
| tree | af1d7c07cea32e0bf12b6d8e39ccac8fe083b634 | |
| parent | 40cc414d10dabacf34877f4902279729ca3bc011 (diff) | |
executor: skip setsid() for threaded reproducers
Lately, I've been looking into why such low amount of syz reproducers on
OpenBSD are turned into C reproducers. One thing I did notice is that
such syz reproducers have one thing in common: they use the
threaded=true and sandbox=none parameters. Such C reproducer always
exits non-zero early on since the call to setsid() fails with EPERM.
Meaning, the calling process is already a process group leader.
Not sure if the preprocessor conditional should be tweaked in order to
avoid unwanted side effects on other BSDs or configurations.
| -rw-r--r-- | executor/common_bsd.h | 9 | ||||
| -rw-r--r-- | pkg/csource/generated.go | 9 |
2 files changed, 14 insertions, 4 deletions
diff --git a/executor/common_bsd.h b/executor/common_bsd.h index a98d3e4cb..7ccd1053f 100644 --- a/executor/common_bsd.h +++ b/executor/common_bsd.h @@ -389,8 +389,13 @@ static long syz_extract_tcp_res(volatile long a0, volatile long a1, volatile lon static void sandbox_common() { - if (setsid() == -1) - fail("setsid failed"); +#if !SYZ_THREADED +#if SYZ_EXECUTOR + if (!flag_threaded) +#endif + if (setsid() == -1) + fail("setsid failed"); +#endif // Some minimal sandboxing. struct rlimit rlim; diff --git a/pkg/csource/generated.go b/pkg/csource/generated.go index 936b1d66d..5f38c02c6 100644 --- a/pkg/csource/generated.go +++ b/pkg/csource/generated.go @@ -1894,8 +1894,13 @@ static long syz_extract_tcp_res(volatile long a0, volatile long a1, volatile lon static void sandbox_common() { - if (setsid() == -1) - fail("setsid failed"); +#if !SYZ_THREADED +#if SYZ_EXECUTOR + if (!flag_threaded) +#endif + if (setsid() == -1) + fail("setsid failed"); +#endif struct rlimit rlim; #ifdef GOOS_freebsd rlim.rlim_cur = rlim.rlim_max = 128 << 20; |