diff options
| author | Aleksandr Nogikh <nogikh@google.com> | 2026-02-27 11:45:15 +0000 |
|---|---|---|
| committer | Aleksandr Nogikh <nogikh@google.com> | 2026-03-04 18:19:12 +0000 |
| commit | a9fe5c9ea5a79ea37834f2c5be830d0385f20199 (patch) | |
| tree | 3b996f7b5e76dae9c0451f34c93a604faf966350 | |
| parent | ccdcad97ffb81efdf1d1c0a06bae8b57da28991d (diff) | |
syz-cluster: only retest findings with reproducers
There are findings without one (e.g. build errors), and it makes no
sense to rerun them.
| -rw-r--r-- | syz-cluster/pkg/controller/api_test.go | 8 | ||||
| -rw-r--r-- | syz-cluster/pkg/service/finding.go | 3 |
2 files changed, 11 insertions, 0 deletions
diff --git a/syz-cluster/pkg/controller/api_test.go b/syz-cluster/pkg/controller/api_test.go index 297b20b3f..de9e1fa59 100644 --- a/syz-cluster/pkg/controller/api_test.go +++ b/syz-cluster/pkg/controller/api_test.go @@ -236,11 +236,18 @@ func TestAPIListPreviousFindings(t *testing.T) { SessionID: idsV1.SessionID, Title: "Crash in foo", TestName: "test", + SyzRepro: []byte("syz repro"), })) require.NoError(t, client.UploadFinding(ctx, &api.RawFinding{ SessionID: idsV1.SessionID, Title: "Crash in bar", TestName: "test", + SyzRepro: []byte("syz repro"), + })) + require.NoError(t, client.UploadFinding(ctx, &api.RawFinding{ + SessionID: idsV1.SessionID, + Title: "Build error without repro", + TestName: "test", })) MarkSessionFinished(t, env, idsV1.SessionID) @@ -266,6 +273,7 @@ func TestAPIListPreviousFindings(t *testing.T) { SessionID: idsV2.SessionID, Title: "Crash in foo", TestName: "test", + SyzRepro: []byte("syz repro"), })) MarkSessionFinished(t, env, idsV2.SessionID) diff --git a/syz-cluster/pkg/service/finding.go b/syz-cluster/pkg/service/finding.go index d8d7c46ca..9d1b09c6c 100644 --- a/syz-cluster/pkg/service/finding.go +++ b/syz-cluster/pkg/service/finding.go @@ -205,6 +205,9 @@ func (s *FindingService) ListPreviousFindings(ctx context.Context, req *api.List if !finding.InvalidatedAt.IsNull() { continue } + if finding.CReproURI == "" && finding.SyzReproURI == "" { + continue + } allFindings = append(allFindings, finding) } } |
